fix(caldav): Add all selected columns to GROUP BY
#47996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
|
Seems related to 67957e9 |
|
/backport d100c20 to stable30 |
Signed-off-by: Git'Fellow <[email protected]> fix: code style Signed-off-by: Git'Fellow <[email protected]>
solracsf
force-pushed
the
addAllToGroupBy
branch
from
02c3962
to
932bf6e
Compare
|
Dup of #47399 |
|
Okay! Feel free to close here then 👍 |
4 tasks
|
Unfortunately this fails, at least with strict mysql
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added all the fields from the SELECT clause to the GROUP BY. This way, the query adheres to the ONLY_FULL_GROUP_BY mode.
Checklist